Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Periskop Server: Merge exceptions instead of swapping #128

Closed
jcreixell opened this issue May 28, 2020 · 0 comments
Closed

Periskop Server: Merge exceptions instead of swapping #128

jcreixell opened this issue May 28, 2020 · 0 comments
Assignees

Comments

@jcreixell
Copy link
Contributor

Currently we swap one snapshot of services for another, resulting in an exact snapshot of errors from the last scrape.

This approach is simple but has the disadvantage of losing exception information after a deployment revert and posterior debugging, which is the first thing that happens on a bad deploy.

A more useful alternative would be to do a shallow merge of exceptions, so that older ones remain kept in memory. This does not solve the problem of losing exception information between Periskop deploys (which could be solved by introducing persistent storage), but it is an improvement over the current situation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants