Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

respect org.freedesktop.appearance dark/light theme setting #665

Open
RushingAlien opened this issue May 11, 2023 · 2 comments
Open

respect org.freedesktop.appearance dark/light theme setting #665

RushingAlien opened this issue May 11, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@RushingAlien
Copy link

Is your feature request related to a problem? Please describe.
Currently, the modern Linux standard for setting a dark theme, is the org.freedesktop.appearance key, which is a toolkit agnostic setting. I don't know if this is implemented in Flutter, but Soundux doesn't seem to follow it while rhymdport, another flutter app, does.

Describe the solution you'd like
For soundux to listen the the org.freedesktop.appearance key to set a dark theme if the key is available even when set to "no preferences"

Describe alternatives you've considered
Setting a dark GTK theme

Additional context

Desktop (please complete the following information):

  • Environment: Linux Flathub
@RushingAlien RushingAlien added the enhancement New feature or request label May 11, 2023
@Curve
Copy link
Member

Curve commented May 11, 2023

I don't know if this is implemented in Flutter

Soundux doesn't use Flutter ^^ But we do have an implementation for respecting the system theme, maybe it's broken somehow

@RushingAlien
Copy link
Author

Soundux doesn't use Flutter

Ah, my bad. Just read that it uses webkit2gtk on Linux

But we do have an implementation for respecting the system theme

Don't worry, it works, but it listens to gtk-application-prefer-dark-theme instead of the new standard, org.freedesktop.appearance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants