Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should return "*" instead of "" #12

Closed
sounisi5011 opened this issue Jul 9, 2019 · 0 comments · Fixed by #13
Closed

Should return "*" instead of "" #12

sounisi5011 opened this issue Jul 9, 2019 · 0 comments · Fixed by #13
Labels
enhancement New feature or request

Comments

@sounisi5011
Copy link
Owner

semver.validRange() returns "*" for all matching version ranges.

const semver = require('semver')

semver.validRange('x.x.x') === '*'
semver.validRange('*') === '*'
semver.validRange('') === '*'

However, intersect() returns an empty string.

const { intersect } = require('semver-range-intersect')

intersect('x.x.x') === ''
intersect('*') === ''
intersect('') === ''
@sounisi5011 sounisi5011 added the enhancement New feature or request label Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant