Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu button clipping #8

Closed
soup-bowl opened this issue Mar 7, 2023 · 7 comments · Fixed by #25
Closed

Menu button clipping #8

soup-bowl opened this issue Mar 7, 2023 · 7 comments · Fixed by #25
Assignees
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@soup-bowl
Copy link
Owner

image

There appears to be a clipping issue, with the menu button appearing to get cut off on the right-hand side. So far experienced in Xubuntu 22.04, and in the Gitpod instance.

@soup-bowl soup-bowl added the bug Something isn't working label Mar 7, 2023
@soup-bowl
Copy link
Owner Author

I find that setting:

#TabsToolbar .toolbar-items,
#TabsToolbar-customization-target {
	width:100%;
}

Shows the full length of the tab bar again, like so:

image

But I cannot seem to achieve the same with the navbar. I've also tried setting this to higher up elements, without success.

@AlexyBot
Copy link

By hiding the menu button on userChrome.css the padding seems to be fixed
At the beginning of userChrome.css

...
@import "urlbar.css";
#PanelUI-button { display:none!important; }
#main-window {
...

Ends up looking like this.

screen

Since the theme itself requires the menu bar to work correctly, it is safe to hide the menu button

@soup-bowl
Copy link
Owner Author

soup-bowl commented May 11, 2023

Good point @AlexyBot. If you're happy for me to I'd like to put that in the readme as a user preference.

I'm not going to roll that into the main theme as I'd rather fix the source than hide the button, especially as I intend to eventually make the theme work with and without the menubar. But as a user preference it's good.

@AlexyBot
Copy link

Go ahead, you're the theme creator after all :p
Love the work you're doing here <3

@soup-bowl soup-bowl added the help wanted Extra attention is needed label Aug 18, 2023
@TheiaDraizer
Copy link

@AlexyBot
To fix this bug, go to
chrome->toolbar.css
open it
find a line that starts with "#nav-bar {"
insert this line at the end:

padding-right: 20px !important;

as shown in the picture:
image

result:
image

@soup-bowl
Copy link
Owner Author

soup-bowl commented Jan 23, 2024

Good spot @TheiaDraizer. Helps to debug this a bit better. Looks like perhaps the list-item layout of the m enu button now overlap, providing it a bit of a gap to lean into. I'm going to test this a bit more as I needed to specify a different value else it would have a noticable gap, but otherwise looks like the right track.

@soup-bowl soup-bowl linked a pull request Jan 23, 2024 that will close this issue
@soup-bowl
Copy link
Owner Author

soup-bowl commented Jan 26, 2024

Adjustments have been made to make it account for Compact, Normal and Touch modes. There's probably a better way to do it, but for lack of discovering one - this one should make this theme reusable for people again. Thanks all for the assist on this.

@AlexyBot FYI this will make a padded space on your adjustment. I've updated the instructions on the readme so you can keep it looking like you wanted.

I'll keep this pinned & in the readme until 0.8 is tagged, as people using the releases will not see this fixed. 0.8

@soup-bowl soup-bowl unpinned this issue Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants