Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simplify gathered data #2

Closed
souporserious opened this issue Jul 31, 2022 · 1 comment · Fixed by #5
Closed

simplify gathered data #2

souporserious opened this issue Jul 31, 2022 · 1 comment · Fixed by #5

Comments

@souporserious
Copy link
Owner

souporserious commented Jul 31, 2022 •
edited

Right now a Map is used to store all data since it is more performant and this simplifies updating data. However, this isn't feasible for storing server data right now as it is rather large as seen in the screenshot below:

large amount of json data from a reforest tree render

This should instead be stored as nested arrays since they will be ordered properly and don't need indexPathString which is rather large to tack on to the data. In general, this probably warrants proper serialize/deserialize utilities.
@souporserious
Copy link
Owner Author

Thinking through this more, only the computed data should be stored since that's the only thing server renders care about and will be even better for performance ✨

@souporserious souporserious mentioned this issue Jul 31, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix initial computed data souporserious/reforest
1 participant
@souporserious