Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Avenger Backlog Notifications #1070

Draft
wants to merge 16 commits into
base: master
Choose a base branch
from
Draft

Fix Avenger Backlog Notifications #1070

wants to merge 16 commits into from

Conversation

GabrielCWT
Copy link
Contributor

@GabrielCWT GabrielCWT commented Feb 24, 2024 •
edited by RichDom2185

  • Implement dedicated function for getting ungraded submissions. It fetches only the bare minimum (assessment_title, student_name, submission_id and course_id)
  • Refactor avenger backlog email template to use new function
  • Refactor cron job to use new function
  • Include status: submitted in test seed submissions
  • Refactor tests to use the dedicated function

Closes #1040

Closes #1032
Closes #939

@GabrielCWT
feat: Implement ungraded submission function
5700203 
A dedicated function for Avenger backlog email notifications, it only fetches necessities (assessment_title, student_name and submission_id)
@GabrielCWT
refactor: Update template to use new function
51b7fff
@GabrielCWT
refactor: Cron job to use new function
a422e2c
@GabrielCWT GabrielCWT linked an issue Feb 24, 2024 that may be closed by this pull request
Improve email generation logic #1032
Open
@coveralls
Copy link

coveralls commented Feb 24, 2024 •
edited

Coverage Status

coverage: 94.998% (+0.006%) from 94.992%
when pulling 2095250 on GabrielCWT:fix/notifications
into 11154a6 on source-academy:master.

@GabrielCWT GabrielCWT marked this pull request as draft February 25, 2024 01:13
@GabrielCWT
Copy link
Contributor Author

GabrielCWT commented Feb 25, 2024 •
edited

Changed back to draft as I would like to update notification links as well. @RichDom2185 any ideas on how would I get frontend url, is there an env variable I can use? Also I don't think there is an unsubscribe link as of yet

Edit: Probably can use cors_endpoints for frontend url.

@GabrielCWT
Copy link
Contributor Author

GabrielCWT commented Feb 25, 2024 •
edited

TODO:

  • Update unsubscribe link
  • Update url builder to use frontend url (Currently hardcoded to sourceacademy)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RichDom2185 RichDom2185 Awaiting requested review from RichDom2185

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve email generation logic Update notification links Fix Avenger backlog email generation
2 participants
@GabrielCWT @coveralls