Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P2Fancy: SourceAcademy GitHub Classroom with central repository #1771

Merged
merged 480 commits into from
Jun 21, 2021

Conversation

chekjun
Copy link
Contributor

@chekjun chekjun commented Jun 6, 2021

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Code quality improvements

How to test

  1. Request to join the test GitHub classroom named 'source-academy-course-test'.
  2. Request to be added as member of the GitHub Organization 'source-academy-course-test'.
  3. Run Source Academy on localhost.
  4. Click on Classrooms in the primary (topmost) navbar.
  5. Click login and sign in with your GitHub account.
  6. Select course 'source-academy-course-test'.
  7. Click on Missions (there should be 3 visible mission cards with their accept buttons).
  8. Click on accept for any of the missions and follow the procedure to accept the GitHub Classroom assessment.
  9. Click on Missions again (the 'accept' button should change to 'open').
  10. Click on Quests (there should be 1 visible quest card with accept button).

Checklist

  • I have tested this code
  • I have updated the documentation

chekjun and others added 30 commits April 22, 2021 14:54
Tests for GitHubMissionDataUtils
Increased code coverage for GitHubMissionDataUtils
Shifted working GitHubLogin to the navbar
Added date support to the mission browser
refactor: removed outdated code
@chownces chownces linked an issue Jun 21, 2021 that may be closed by this pull request
@chownces chownces merged commit 65db52c into source-academy:master Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitHub classroom: white navbar is not sticking to the top
5 participants