Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INTERACTIVE SICP JS: Fix mobile control bar not showing up #1788

Merged
merged 1 commit into from
Jun 14, 2021
Merged

INTERACTIVE SICP JS: Fix mobile control bar not showing up #1788

merged 1 commit into from
Jun 14, 2021

Conversation

samuelfangjw
Copy link
Contributor

@samuelfangjw samuelfangjw commented Jun 14, 2021 •
edited
Loading

Description

Before:
Screenshot 2021-06-14 at 11 00 42 AM

After:
Screenshot 2021-06-14 at 11 00 30 AM

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Code quality improvements

How to test

Check that control bar appears when viewing a code snippet on mobile.

Checklist

  • I have tested this code
  • I have updated the documentation

@coveralls
Copy link

Pull Request Test Coverage Report for Build 934430073

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 30.238%
Totals Coverage Status
Change from base Build 934329204: 0.0%
Covered Lines: 3231
Relevant Lines: 9865
💛 - Coveralls

@samuelfangjw samuelfangjw changed the title INTERACTIVE SICP: Fix mobile control bar not showing up INTERACTIVE SICP JS: Fix mobile control bar not showing up Jun 14, 2021
martin-henz
martin-henz approved these changes Jun 14, 2021
View reviewed changes
Copy link
Member

@martin-henz martin-henz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whatever works!

@martin-henz martin-henz merged commit 7b5881d into source-academy:master Jun 14, 2021
@samuelfangjw samuelfangjw deleted the fix-mobile-controlbar-hidden branch June 14, 2021 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martin-henz martin-henz martin-henz approved these changes

@YaleChen299 YaleChen299 Awaiting requested review from YaleChen299

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@samuelfangjw @coveralls @martin-henz