-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added caching of Github credentials #1792
Merged
martin-henz
merged 6 commits into
source-academy:master
from
chownces:github-persistence
Jul 16, 2021
Merged
Added caching of Github credentials #1792
martin-henz
merged 6 commits into
source-academy:master
from
chownces:github-persistence
Jul 16, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 967129830
💛 - Coveralls |
Pull Request Test Coverage Report for Build 1035823582
💛 - Coveralls |
martin-henz
approved these changes
Jul 16, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
security concerns discussed (and dismissed) in telegram "SA 2122 Summer Development"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
DO NOT MERGE YET (potential security risk)
I'm not sure how our GitHub OAuth app has been configured, but by default the access tokens do not have an expiry date... The optional setting for expiring tokens as stated in GitHub's documentation seems to be missing too.
This is potentially very dangerous, as we are storing this account-wide access token in local storage.
Type of change
How to test
Log in to our GitHub Assessments page and refresh the browser.
Checklist