Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Game] Fix RoomPreview params #1793

Merged
merged 3 commits into from
Jun 16, 2021
Merged

Conversation

gok99
Copy link
Contributor

@gok99 gok99 commented Jun 15, 2021

Description

Wraps game params that are passed into js-slang context for the game module.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Code quality improvements

How to test

Under Go to My Room in source academy game with default room code, a gif of a mummy walking with the words Welcome to Source Academy! should appear

Checklist

  • I have tested this code

@coveralls
Copy link

coveralls commented Jun 15, 2021

Pull Request Test Coverage Report for Build 942281933

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 30.233%

Totals Coverage Status
Change from base Build 942236889: 0.0%
Covered Lines: 3230
Relevant Lines: 9864

💛 - Coveralls

@gok99 gok99 merged commit 29e8388 into source-academy:master Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants