Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Urls for textbook updated #1797

Merged
merged 11 commits into from
Jun 16, 2021
Merged

Urls for textbook updated #1797

merged 11 commits into from
Jun 16, 2021

Conversation

martin-henz
Copy link
Member

@martin-henz martin-henz commented Jun 16, 2021 •
edited
Loading

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Code quality improvements

How to test

Checklist

  • I have tested this code
  • I have updated the documentation

@cloudflare-pages
Copy link

cloudflare-pages bot commented Jun 16, 2021 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1e2a305
Status: ✅  Deploy successful!
Preview URL: https://4a80335a.cadet-frontend.pages.dev

View logs

@coveralls
Copy link

coveralls commented Jun 16, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 943058521

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 30.231%
Totals Coverage Status
Change from base Build 943011553: -0.01%
Covered Lines: 3231
Relevant Lines: 9865
💛 - Coveralls

samuelfangjw
samuelfangjw previously approved these changes Jun 16, 2021
View reviewed changes
Copy link
Contributor

@samuelfangjw samuelfangjw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested links, LGTM!

samuelfangjw
samuelfangjw approved these changes Jun 16, 2021
View reviewed changes
Copy link
Contributor

@samuelfangjw samuelfangjw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@samuelfangjw
Merge branch 'master' of github.com:source-academy/cadet-frontend int…
f0ef1b6 
…o urls

# Conflicts:
#	src/features/sicp/parser/ParseJson.tsx
#	src/features/sicp/parser/__tests__/__snapshots__/ParseJson.tsx.snap
@samuelfangjw
Fix failing test snapshots
1e2a305
@martin-henz martin-henz merged commit 34ba701 into master Jun 16, 2021
@samuelfangjw samuelfangjw deleted the urls branch June 16, 2021 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelfangjw samuelfangjw samuelfangjw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@martin-henz @coveralls @samuelfangjw