Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playground Persistence Enhancement (fix issue #1787) #1799

Merged

Conversation

ChengGeng97
Copy link
Contributor

Description

Meant to fix this issue: #1787

Type of change

  • Enhancement

How to test

  • Open or save a new file. GitHub button text will change to reflect the file name.
  • If changes are made in the editor after the latest open or save, the color of the file name text will change to orange. If there are no such unsaved changes, the color of the file name text will be blue.
  • Additional dialog to confirm a save for a new file has been removed.

@coveralls
Copy link

coveralls commented Jun 17, 2021

Pull Request Test Coverage Report for Build 945292967

  • 2 of 18 (11.11%) changed or added relevant lines in 5 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.06%) to 30.179%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/features/playground/PlaygroundActions.ts 1 2 50.0%
src/pages/playground/Playground.tsx 0 2 0.0%
src/features/github/GitHubUtils.tsx 0 3 0.0%
src/commons/controlBar/github/ControlBarGitHubButtons.tsx 0 10 0.0%
Files with Coverage Reduction New Missed Lines %
src/commons/controlBar/github/ControlBarGitHubButtons.tsx 1 2.78%
Totals Coverage Status
Change from base Build 945210705: -0.06%
Covered Lines: 3231
Relevant Lines: 9872

💛 - Coveralls

Copy link
Member

@martin-henz martin-henz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very reasonable.

@martin-henz
Copy link
Member

(difficult to test; so much easier to test after deployment, so that's what I will do, and follow up if necessary)

@martin-henz martin-henz merged commit 3adfe7e into source-academy:master Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants