Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interactive SICP-JS: Changes to style and formatting #1800

Merged
merged 4 commits into from
Jun 17, 2021

Conversation

samuelfangjw
Copy link
Contributor

@samuelfangjw samuelfangjw commented Jun 17, 2021

Description

  1. Adjust spacing of authors section on index page
    Before:

Screenshot 2021-06-17 at 6 58 14 PM

After:

Screenshot 2021-06-17 at 6 58 11 PM

  1. Add elevation to code snippets. On hover, change cursor to pointer and increase elevation. Currently, it's not very obvious that code snippets can be clicked, this should make it a little more obvious.
Screen.Recording.2021-06-17.at.7.00.56.PM.mov
  1. Make caret in table of contents larger. On hover, change colour to indicate that it can be clicked. The current caret is a little too small and could be made more obvious.
Screen.Recording.2021-06-17.at.7.03.15.PM.mov
  1. Fix margins around block quotes. Block quotes now have a fixed margin of 10px on the top and bottom. Previously there was no margin on the top.

Screenshot 2021-06-17 at 7 05 07 PM

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Code quality improvements

How to test

Ensure the changes described in the description are present.

Checklist

  • I have tested this code
  • I have updated the documentation

@coveralls
Copy link

Pull Request Test Coverage Report for Build 946161428

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 30.179%

Totals Coverage Status
Change from base Build 945411239: 0.0%
Covered Lines: 3231
Relevant Lines: 9872

💛 - Coveralls

@martin-henz martin-henz self-requested a review June 17, 2021 14:21
Copy link
Member

@martin-henz martin-henz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice attention to detail.

@martin-henz martin-henz merged commit 39798d1 into source-academy:master Jun 17, 2021
@samuelfangjw samuelfangjw deleted the style-changes branch June 17, 2021 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants