Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interactive-SICP: Mobile bug fixes #1805

Merged
merged 4 commits into from
Jun 18, 2021

Conversation

samuelfangjw
Copy link
Contributor

@samuelfangjw samuelfangjw commented Jun 18, 2021

Description

  1. Left-align text instead of justify
    Justified text is hard to read when there are short lines (common when viewing on mobile) and is generally thought to be a bad idea on web text. Changed to left align instead.

  2. Set default image scale to 100%.
    Images on mobile were not scaled properly, requiring users to scroll left and right to see the full image. Images now default to 100% scale. This can be overridden by changing web_scale property in xml files.
    Before:

Screenshot 2021-06-18 at 4 24 14 PM

After:
Screenshot 2021-06-18 at 4 25 41 PM

This change affects the desktop version as well for consistency, with images now scaled to 100% width unless otherwise specified.
Screenshot 2021-06-18 at 4 27 05 PM

  1. Table of contents on mobile version was slightly off centre, I've changed it to be a bit more centralised, and added a slightly larger gap between the caret and the label so that it is easier to press.

Before:
Screenshot 2021-06-18 at 4 28 36 PM

After:
Screenshot 2021-06-18 at 4 28 45 PM

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Code quality improvements

How to test

Ensure changes in description are working correctly.

Checklist

  • I have tested this code
  • I have updated the documentation

@coveralls
Copy link

Pull Request Test Coverage Report for Build 949222549

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 30.177%

Totals Coverage Status
Change from base Build 948313670: 0.01%
Covered Lines: 3229
Relevant Lines: 9871

💛 - Coveralls

@martin-henz martin-henz self-requested a review June 18, 2021 09:00
Copy link
Member

@martin-henz martin-henz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Yes for small displays, the text should be lef-aligned.

@martin-henz martin-henz merged commit 2870d76 into source-academy:master Jun 18, 2021
@samuelfangjw samuelfangjw deleted the mobile-fixes branch June 19, 2021 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants