Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File Explorer fix for #1787 #1810

Merged

Conversation

ChengGeng97
Copy link
Contributor

Description

Fix for #1787. File Explorer Dialog now closes when save is confirmed.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How to test

  • Open or save a new file. GitHub button text will change to reflect the file name.
  • If changes are made in the editor after the latest open or save, the color of the file name text will change to orange. If there are no such unsaved changes, the color of the file name text will be blue.
  • Additional dialog to confirm a save for a new file has been removed.
  • Use the save-as option to create a new file. The file explorer should not linger.

Checklist

  • I have tested this code

@coveralls
Copy link

coveralls commented Jun 18, 2021

Pull Request Test Coverage Report for Build 949466133

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 30.182%

Totals Coverage Status
Change from base Build 949302818: 0.005%
Covered Lines: 3230
Relevant Lines: 9872

💛 - Coveralls

Copy link
Member

@martin-henz martin-henz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@martin-henz martin-henz merged commit 35c076d into source-academy:master Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants