Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SICP-INTERACTIVE: Fix scrolling behaviour #1811

Merged
merged 2 commits into from
Jun 19, 2021
Merged

SICP-INTERACTIVE: Fix scrolling behaviour #1811

merged 2 commits into from
Jun 19, 2021

Conversation

samuelfangjw
Copy link
Contributor

@samuelfangjw samuelfangjw commented Jun 19, 2021 •
edited
Loading

Description

Fixes #1809

Screen.Recording.2021-06-19.at.1.17.02.PM.mov

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Code quality improvements

How to test

Verify scrolling works when clicking on link within text.

Checklist

  • I have tested this code
  • I have updated the documentation

@coveralls
Copy link

Pull Request Test Coverage Report for Build 951855133

  • 2 of 3 (66.67%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 30.182%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/pages/sicp/Sicp.tsx 2 3 66.67%
Totals Coverage Status
Change from base Build 949489893: 0.0%
Covered Lines: 3230
Relevant Lines: 9872
💛 - Coveralls

martin-henz
martin-henz approved these changes Jun 19, 2021
View reviewed changes
Copy link
Member

@martin-henz martin-henz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@martin-henz martin-henz merged commit 840cc11 into source-academy:master Jun 19, 2021
@samuelfangjw samuelfangjw deleted the scroll-fix branch June 19, 2021 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martin-henz martin-henz martin-henz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Interactive SICP: clicking on footnote goes into inconsistent state
3 participants
@samuelfangjw @coveralls @martin-henz