Interactive Sicp Bug Fixes #1812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 955780461
💛 - Coveralls |
…o bug-fixes # Conflicts: # src/pages/sicp/Sicp.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For the following screenshots, before is on the left and after is on the right.
Added an error boundary to catch errors and display a fallback UI.
Tweak font size for math so that they are the same size as surrounding text.
Change redirect component in table of contents to use useHistory hook instead. Previously, when viewing on GitHub pages, if one goes to a new page via the table of contents the new page will not be added to the browser history (cannot press the back button). This should fix that.
Fix issue where direct link to an element will not work on first page load. Also ensure that we always scroll to the top of the element.
Type of change
How to test
Verify changes have been made
Checklist