Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interactive sicp: add navigation buttons to bottom of page #1815

Merged
merged 6 commits into from
Jun 21, 2021

Conversation

samuelfangjw
Copy link
Contributor

Description

Screenshot 2021-06-20 at 1 57 28 PM

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Code quality improvements

How to test

Check that navigation buttons go to next page and previous page correctly.

Checklist

  • I have tested this code
  • I have updated the documentation

@coveralls
Copy link

coveralls commented Jun 20, 2021

Pull Request Test Coverage Report for Build 954302666

  • 16 of 22 (72.73%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 30.212%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/commons/navigationBar/subcomponents/SicpNavigationBar.tsx 7 10 70.0%
src/pages/sicp/Sicp.tsx 3 6 50.0%
Totals Coverage Status
Change from base Build 954167627: 0.03%
Covered Lines: 3230
Relevant Lines: 9871

💛 - Coveralls

@martin-henz
Copy link
Member

Good idea.

@martin-henz martin-henz self-requested a review June 21, 2021 01:06
Copy link
Member

@martin-henz martin-henz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@martin-henz martin-henz merged commit 3245d0a into source-academy:master Jun 21, 2021
@samuelfangjw samuelfangjw deleted the navigation-buttons branch June 21, 2021 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants