Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removing inspector tab #1816

Merged
merged 5 commits into from
Jun 21, 2021
Merged

removing inspector tab #1816

merged 5 commits into from
Jun 21, 2021

Conversation

martin-henz
Copy link
Member

@martin-henz martin-henz commented Jun 21, 2021 •
edited
Loading

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Code quality improvements

How to test

Checklist

  • I have tested this code
  • I have updated the documentation

@martin-henz
Copy link
Member Author

martin-henz commented Jun 21, 2021 •
edited
Loading

The Steering Committee reached a consensus to remove the Inspector Tab. I took a look and discovered that the the inspector component in js-slang serves as tool to keep track of the line numbers when debugging. The "inspector" in cadet-frontend serves as model component: representing the state of the running program.

This role of "inspector" makes sense, regardless whether we have an "Inspector" tab or not.

This PR therefore proposes to keep the "inspector" interface in js-slang and the model component of "inspector" in cadet-frontend.

The PR proposes just to remove the Inspector tab.

Any views welcome.

@cloudflare-pages
Copy link

cloudflare-pages bot commented Jun 21, 2021 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 59dc382
Status: ✅  Deploy successful!
Preview URL: https://089ddb17.cadet-frontend.pages.dev

View logs

@coveralls
Copy link

coveralls commented Jun 21, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 957094147

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 30.087%
Totals Coverage Status
Change from base Build 957067211: -0.01%
Covered Lines: 3208
Relevant Lines: 9823
💛 - Coveralls

@samuelfangjw samuelfangjw self-requested a review June 21, 2021 09:49
samuelfangjw
samuelfangjw reviewed Jun 21, 2021
View reviewed changes
Copy link
Contributor

@samuelfangjw samuelfangjw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I made some additional changes.

src/styles/_workspace.scss
@@ -377,32 +377,6 @@ $code-color-error: #ff4444;
}
}

##{$ns}-tab-panel_side-content-tabs_inspector {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed unused styles

public/externalLibs/inspector/inspector.js
@@ -1,225 +1,4 @@
(function (exports) {
var container = document.createElement('div');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The functions I've removed don't seem to be referenced anymore. This means that this file (named inspector.js) is now only responsible for highlighting lines (when debugging).

@martin-henz martin-henz merged commit bed351d into master Jun 21, 2021
@samuelfangjw samuelfangjw mentioned this pull request Jun 21, 2021
Closed
@jiayushe jiayushe deleted the inspectorBgone branch September 7, 2021 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelfangjw samuelfangjw samuelfangjw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@martin-henz @coveralls @samuelfangjw