Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interactive Sicp: Fix share link not working and increase editor size #1819

Merged
merged 5 commits into from
Jun 23, 2021
Merged

Interactive Sicp: Fix share link not working and increase editor size #1819

merged 5 commits into from
Jun 23, 2021

Conversation

samuelfangjw
Copy link
Contributor

Description

As per description.

Screenshot 2021-06-22 at 11 18 44 PM

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Code quality improvements

How to test

Check that share link works, and visually confirm editor size has increased and scales with display size up to a maximum size of 1600px.

Checklist

  • I have tested this code
  • I have updated the documentation

@coveralls
Copy link

coveralls commented Jun 22, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 962607643

  • 0 of 3 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.0007%) to 30.072%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/pages/playground/Playground.tsx 0 3 0.0%
Totals Coverage Status
Change from base Build 961295365: -0.0007%
Covered Lines: 3208
Relevant Lines: 9827
💛 - Coveralls

@martin-henz martin-henz self-requested a review June 23, 2021 01:00
martin-henz
martin-henz approved these changes Jun 23, 2021
View reviewed changes
Copy link
Member

@martin-henz martin-henz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine

@martin-henz martin-henz merged commit e0efc3a into source-academy:master Jun 23, 2021
@samuelfangjw samuelfangjw deleted the bug-fixes branch June 24, 2021 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martin-henz martin-henz martin-henz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@samuelfangjw @coveralls @martin-henz