Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update routes from interactive-sicp to sicpjs #1822

Merged

Conversation

samuelfangjw
Copy link
Contributor

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Code quality improvements

How to test

Checklist

  • I have tested this code
  • I have updated the documentation

@coveralls
Copy link

coveralls commented Jun 24, 2021

Pull Request Test Coverage Report for Build 966611939

  • 2 of 5 (40.0%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 30.072%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/commons/navigationBar/subcomponents/SicpNavigationBar.tsx 0 1 0.0%
src/pages/sicp/Sicp.tsx 0 1 0.0%
src/pages/sicp/subcomponents/SicpToc.tsx 0 1 0.0%
Totals Coverage Status
Change from base Build 966583597: 0.0%
Covered Lines: 3208
Relevant Lines: 9827

💛 - Coveralls

@martin-henz martin-henz merged commit 12b80ab into source-academy:master Jun 24, 2021
@samuelfangjw samuelfangjw deleted the change-route-to-sicpjs branch June 24, 2021 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants