add the comment to link the specification #1680
Open
+24
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 10003885284Details
💛 - Coveralls |
…ier-understanding
martin-henz
requested changes
Apr 16, 2024
| @@ -3361,6 +3369,10 @@ export function getEvaluationSteps( | |||
| [], | |||
| 'Start of evaluation' | |||
| ] | |||
| /** | |||
| * push the content into frontend for showing contents in the | |||
There was a problem hiding this comment.
This sentence is not complete: "in the" ...
| /** | ||
| * push the content into frontend for showing contents in the | ||
| * this comment may not be correct, please correct it if you find any mismatch in description | ||
| */ |
There was a problem hiding this comment.
This comment "this comment may not be correct" is quite strange. Are you referring to the one above: "push the content..."?
| /** | ||
| * Deprecated check for empty program | ||
| * It can be deleted or kept as a reference for legacy code. | ||
| */ |
There was a problem hiding this comment.
If the check is deprecated, please delete it.
RichDom2185
reviewed
Apr 16, 2024
…ier-understanding
…ier-understanding
…ier-understanding
|
It seems that this PR is not difficult to fix so that it can be merged. @FYL2003 can you take another look please. |
…ier-understanding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change is uploaded.