-
-
Notifications
You must be signed in to change notification settings - Fork 604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Strange plus #130
Comments
Mind posting your platform and the editor that you are using? Screenshots tend to be very helpful for us to understand what you are seeing. Please include so that we can see the length of those strokes if possible. I haven't noticed this, but we can take a look into it in more detail. |
are you using the otf files by any chance? |
All the Hack files I used to install have the .ttf extension. |
I agree that does not look right and it isn't designed that way. Are you using the current release (v2.015)? I will check the glyph. |
Yes, 2.015. |
I am seeing this also:
Looks fine at all other tested sizes, though. |
@stompychump thanks for letting me know. Can you let me know what other sizes you tested? |
@stompychump thank you very much |
@chrissimpkins the look of the + is very similar to what I was seeing earlier when we were on ChrisRM's issue thread. In the picture, the symbols are spaced out, and is harder to see, so I have a magnified version. And just to restate, using ChrisRM's theme, on font sizes 7 - 11, the top bar of the = sign is missing. I have not tested size 6. But this last thing could be a different issue. |
@ciscorucinski queued up to investigate. Can you remind me of your platform and the editor where you are seeing these issues? Is this still a JetBrains editor? If so, which one and which version? When we discussed this last night you told me that you are using Hack v2.015. Please let me know if this has changed as well. Thanks |
OK, I noticed that the displayed text is different if the text is a Check this video out here - http://tinypic.com/player.php?v=2zhikbt%3E&s=8#.Vi_D6fkrLIU I was going to test of all font sizes from 6 - 14, but noticed this strange behavior. The video shows... On Windows 10 I am switching between pictures I have taken of the same text, but one is commented out, and the other is rendered as if it is code. You will see the + will move up and down, the - remains fairly stable, but the = will lose the top bar. I have the # symbol there for reference. |
Before I had noted that for the = symbol... This issue with the top bar disappearing was only seen when using JB Material Theme in Java, C/C++, and Groovy with font sizes 11 and below. Places like XML, HTML, JSON, etc. didn't have this issue at all. However, I have just come to realize that within Java, the comments with font size 11 DO show the = symbol correctly. Turn off JB Material Theme, and at least the = symbol is displayed correctly...no matter the font size. But I assume the + and - still have their issues |
This |
Would it be possible to check whether you are seeing this in the bold, italic, and bold italic sets as well? |
Thank you very much. This is helpful @stompychump . I am going to try to get this fix in with the next release. Hope to have it out ~ this weekend. Will update here. |
@ciscorucinski Christopher, do you mind opening a separate issue report for the |
@chrissimpkins Yes, I can do that. I have not recieved feedback from ChrisRM yet. He has been gone for over a week. |
@ciscorucinski thank you. Let's see what he has to say before we take on that issue. The behavior suggests that there may be a highlighter specific issue and I will likely need input from him to see if there is something to fix on our end. |
I identified the hinting problems and added new manual instructions to this glyph. This should address these problems. The changes will be part of the upcoming v2.017 release due out this week. Will post here when available. |
The hinted v2.017 ttf release files with this fix are now in the development branch. They are available here if you want to try them hot off the presses: https://github.com/chrissimpkins/Hack/tree/development/build/ttf The official release will take place in the next day or so. Please let me know if you still see problems with the + glyph before we push these. |
@stompychump thank you very much for the images. What text sizes do the comments about the crossbar apply for you? There are ways to address this if it is falling within a commonly used text size range. I suspect that few are using 6/7px sizes, but perhaps I am wrong. |
To my eyes, sizes 8, 9, and 10 now have a blurrier crossbar in v2.017a in the image above (on the right), and also slighty in sizes 11 and 12. Here's an animated image that might make it clearer: For sizes 9-12, I prefer the sharper plus in v2.015. I generally use size 8 though, and for that size it's a toss-up which version I prefer - v2.017a seems blurry, but the original issue is fixed which is great. I realise that there are trade-offs when hinting, so this is just my subjective opinion and not meant as a complaint. |
Just as a side note, the horizontal bar on the If so, then what is being done differently on the The horizontal bar in the
These seem reasonable. The horizontal bar on the
If the horizontal bar was shifted by whole numbers, in this case +1 or -1, then they would be in the correct place an sharp. Note: I have not installed v2.017 yet, and I am only using the animation above. Also, I used the Magnifier App on Windows to look at the zoomed in typeface without further anti-aliasing the font. |
@stompychump What are you doing to get those animated screenshots. My current train-of-thought on doing that with multiple font sizes with the Hack typeface is very cumbersome. I can easily do it with one font size; not multiple. Would it be easy to add testing with a JetBrain IDE into the toolchain? I would like to do this for the whole suite of regular printed characters...easily do multiple font sizes...animated between different style...with a specific IDE |
@ciscorucinski we're not going for pixel perfection (yet). This was a quick monkeypatch for the upcoming release that will be out tonight. The horizontal strokes are now aligned at ~ the midline of the vertical stroke in the post-hinted versions. This led to lines that are straddling pixels at some text sizes. Most text sizes that were mentioned in this issue report were out of alignment by a half pixel in the post-hinted versions and you were noticing this difference in the render. I don't know that we will be able to approach this in the glyph design. I suspect that we are going to need to generate size specific manual hints of the entire glyph (not just the horizontal stroke) across this size range in order to achieve a sharp glyph that is aligned to the pixel grid at each size. This may throw alignment off relative to other glyphs at certain sizes and will require a much more thorough evaluation in order to implement this. We will continue optimizations with upcoming releases and can leave this open to discuss them here. I definitely consider this a high priority glyph for the fonts.
As a side note, we are about to start work on the build toolchain and once this is in place, you are likely to see more frequent iterative updates to the fonts. The releases are currently a significant, largely manual, effort and we intend for this to change (very, very soon). |
All: Changed my mind. I am going to pull these changes out of the upcoming release and we will address them in a bit more detail before we push them. Let's not create more problems in the attempt to fix the original problem. When we have a satisfactory solution, we will go live with it. Do you mind having a look at the bold, italic, and bold-italic sets as well? I made changes across all sets and we may have similar problems with blurred strokes in each area. These changes are very simple to reverse and reimplement. |
All ASCII glyph hints were reviewed from 8-14ppem and modified where necessary as part of our v3.000 release. Please upgrade and let us know if this issue is still a problem for you with these updates. Closing this issue. Please reopen if you would like to discuss further. |
Hey, I like Hack a lot and am considering switching to it. I have to say though that I find the plus sign very strange, I could swear it looks shorter on the bottom than on the top. Am I seeing things? If not, why such an unusual plus?
The text was updated successfully, but these errors were encountered: