Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Underscore too thin, too low, and blurry. #98

Closed
lluixhi opened this issue Sep 12, 2015 · 11 comments
Closed

Underscore too thin, too low, and blurry. #98

lluixhi opened this issue Sep 12, 2015 · 11 comments
Labels

Comments

@lluixhi
Copy link

lluixhi commented Sep 12, 2015

I'm using Linux with the OTF version 2.0.13. My editor is NeoVim.
When lines containing the underscore are right above a cursor, or another character that fills a box (cell?), they're almost indistinguishable from spaces.

underscore

And as said in #97, it looks like the right hand spacing is too big. (They're not centered!)

@chrissimpkins
Copy link
Member

How does the ttf build render for you? In general I would recommend it for screen use over the otf files on Linux.

@lluixhi
Copy link
Author

lluixhi commented Sep 12, 2015

They're even worse in TTF.

2015-09-11_22-09-24

By the way, I have turned off all freetype hinting, have antialiasing and the RGB lcdfilter enabled. If that matters.

@chrissimpkins
Copy link
Member

interesting OK. I will take a look at it. thanks for reporting this.

@lluixhi
Copy link
Author

lluixhi commented Sep 12, 2015

They simply disappeared with the TTF and slight hinting:

hintslight

But they reappear and are extremely clear when full hinting is enabled. Unfortunately, this makes other fonts pretty ugly:
hintfull

@lluixhi
Copy link
Author

lluixhi commented Sep 12, 2015

This is the OTF font with slight hinting:

2015-09-11_22-34-45

And with full hinting:

2015-09-11_22-33-14

@chrissimpkins
Copy link
Member

@lluixhi thank you very much for all of these screenshots Aric. These are very helpful. I have other issue reports on the tilde glyph. We will definitely address all of these.

I will need to look into the box glyphs to see how they align with the underscores. It looks like this is in part a vertical metrics issue (box glyph too close to the underscore) and a horizontal alignment issue (orientation of underscore to the top of the box glyph) if I understand you correctly.

The tilde issue is a separate one. That appears to be related to hinting. We are working on hinting in the ttf builds in other issue threads. The otf instruction sets will be addressed once I have a solid ttf build as the TrueType files are more widely used and across most platforms will display better on the screen than the otf builds. What Linux distro are you on by the way?

@lluixhi
Copy link
Author

lluixhi commented Sep 13, 2015

Yes, that's correct.

I'm on Gentoo using Freetype 2.6. I'm using ST, the suckless terminal: http://st.suckless.org/ (That's what I took the screenshots in).

I think the main reason people on Fedora, Debian, etc. see different results in the font rendering is different distro defaults. I'm pretty sure Fedora turns off the LCD filter (sub pixel rendering) by default due to potential patent issues. Ubuntu and maybe Debian turn it on by default.

Fontconfig/Freetype defaults to Full Hinting and no subpixel rendering, with enabled antialiasing (i believe).. but Ubuntu uses a patched freetype that might change that behaviour.

People using Infinality (a popular patched freetype) are also going to see different results because it tries to mimic rendering on OSX and Windows.

@chrissimpkins
Copy link
Member

@lluixhi headache source #1 at the moment! But a problem that we need to deal with. We will try to make it as usable as possible for everyone. It is likely to take a combination of changes in glyph shapes / alignment and hinting across the TrueType and PostScript builds. Fortunately there are developers across a broad range of renderer, editor, platform combinations who have been willing to test.

@chrissimpkins
Copy link
Member

The position of the underscore is too low in the source and it is off center. I will correct these and plan for this change to be in the next release.

Let me get some additional feedback about the vertical width of the underscore stroke on other platforms before we introduce this change.

@chrissimpkins
Copy link
Member

New test build v2.014 is available that addresses this issue. Vertical metrics were updated, the underscores were made slightly larger in the vertical dimension and they were properly centered.

Files are available in #111. Please let me know what you think.

@chrissimpkins
Copy link
Member

Closing as solved. Please feel free to reopen if the current build does not address your issue. Thanks for the report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants