Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support custom indentation space formatting in write files #18

Closed
chrissimpkins opened this issue Jul 27, 2021 · 5 comments · Fixed by #29
Closed

Support custom indentation space formatting in write files #18

chrissimpkins opened this issue Jul 27, 2021 · 5 comments · Fixed by #29

Comments

@chrissimpkins
Copy link
Member

chrissimpkins commented Jul 27, 2021 •
edited

Related linebender/norad#145

It might be useful for a user to define the type (tab, space) and length (one, two, four) of space formatting in the file writes. This would reduce text diffs relative to other tooling used in a UFO work pipeline. I'm not sure that it is necessary to be dogmatic about this issue. The goal is to achieve consistent formatting and that can be, at least partially, user-defined + project-specific?

This would require support in the norad project.
@chrissimpkins chrissimpkins mentioned this issue Jul 27, 2021
Closed
@chrissimpkins
Copy link
Member Author

linebender/norad#148 🥳

@chrissimpkins chrissimpkins mentioned this issue Jul 30, 2021
Merged
@chrissimpkins
Copy link
Member Author

This is now supported in norad main branch. Will add new options to define space formatting in the ufofmt executable.

@chrissimpkins chrissimpkins changed the title Support custom space formatting in write files Support custom indentation space formatting in write files Sep 7, 2021
@chrissimpkins chrissimpkins mentioned this issue Sep 7, 2021
Merged
2 tasks
@chrissimpkins
Copy link
Member Author

#29

@chrissimpkins
Copy link
Member Author

chrissimpkins commented Sep 10, 2021 •
edited

We will support between 1 - 4 tabs or spaces and use the norad default = single tab indentation per level.

@chrissimpkins
Copy link
Member Author

Added in #29, will be released in v0.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add custom indentation spacing support source-foundry/ufofmt
1 participant
@chrissimpkins