Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle --all-features, --feature, --no-default-features #60

Closed
sourcefrog opened this issue Aug 6, 2022 · 1 comment
Closed

Handle --all-features, --feature, --no-default-features #60

sourcefrog opened this issue Aug 6, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers next Likely to be worked on soon

Comments

@sourcefrog
Copy link
Owner

sourcefrog commented Aug 6, 2022

These options need to be passed consistently to all of check, build, and test.

For example, time-rs/time can't build its tests unless --all-features is specified. time-rs/time#497

More generally people might want to test some crates with specific features.

#59 is about having custom options specifically for the build, but these seem important enough that they might be worth handling specifically.

--release would be another good one to add, either for crates where it significantly helps the test suite speed, or for crates like syn where the test suite insists on --release. (Tangentially, it might actually be a good idea in general, depending on the balance of time between linking and running the test suite...)
This could be tested with a specific testdata tree that fails to build unless a given feature is given.

@sourcefrog sourcefrog added enhancement New feature or request good first issue Good for newcomers next Likely to be worked on soon labels Aug 6, 2022
@sourcefrog sourcefrog self-assigned this Aug 7, 2022
@sourcefrog
Copy link
Owner Author

I think this is handled enough with --cargo-arg (-C) in 8a7126a and related changes. I can use this to build crates like time that don't pass their tests without --all-features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers next Likely to be worked on soon
Projects
None yet
Development

No branches or pull requests

1 participant