Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(component): add a new strategy for otp #67

Merged
merged 4 commits into from
Apr 21, 2022
Merged

Conversation

AnkurBansalSF
Copy link
Contributor

@AnkurBansalSF AnkurBansalSF commented Apr 6, 2022

Description

added a new 2-factor authentication strategy.

Fixes #69

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Intermediate change (work in progress)

Checklist:

  • Performed a self-review of my own code
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Any dependent changes have been merged and published in downstream modules

added a new 2-factor authentication strategy

GH-69
@samarpan-b
Copy link
Contributor

Add readme please. Also we might need default implementation for otp verifier here.

added a new 2-factor authentication strategy.

gh-69
@sonarcloud
Copy link

sonarcloud bot commented Apr 18, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@akshatdubeysf akshatdubeysf merged commit 5f8cd5e into master Apr 21, 2022
@akshatdubeysf akshatdubeysf deleted the otp-strategy branch April 21, 2022 11:29
@yeshamavani
Copy link
Contributor

🎉 This PR is included in version 6.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Two-factor authentication
4 participants