Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(chore): fix sonar code smells #122

Merged
merged 3 commits into from
May 16, 2023
Merged

fix(chore): fix sonar code smells #122

merged 3 commits into from
May 16, 2023

Conversation

arpit1503khanna
Copy link
Contributor

@arpit1503khanna arpit1503khanna commented Mar 20, 2023 •
edited by RaghavaroraSF
Loading

Description

Resolving sonar smells to improve quality gate

GH-111
Fixes #111

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Intermediate change (work in progress)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • Performed a self-review of my own code
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Any dependent changes have been merged and published in downstream modules

yeshamavani
yeshamavani requested changes Mar 21, 2023
View reviewed changes
src/providers/push/apns/apns.provider.ts Outdated Show resolved Hide resolved
src/providers/push/fcm/fcm.provider.ts Outdated Show resolved Hide resolved
src/providers/push/fcm/fcm.provider.ts Outdated Show resolved Hide resolved
src/providers/push/fcm/fcm.provider.ts Outdated Show resolved Hide resolved
@shubhamp-sf
Copy link
Contributor

@arpit1503khanna kindly address the changes requested.

shubhamp-sf
shubhamp-sf requested changes Apr 20, 2023
View reviewed changes
src/providers/push/fcm/fcm.provider.ts Outdated Show resolved Hide resolved
src/providers/push/apns/apns.provider.ts Outdated Show resolved Hide resolved
src/providers/push/apns/apns.provider.ts Outdated Show resolved Hide resolved
src/providers/push/apns/apns.provider.ts Outdated Show resolved Hide resolved
src/providers/push/apns/types.ts Outdated Show resolved Hide resolved
src/providers/push/socketio/types.ts Outdated Show resolved Hide resolved
src/types.ts Outdated Show resolved Hide resolved
@RaghavaroraSF RaghavaroraSF changed the title fix(chore): fixing sonar smells fix(chore): fix sonar code smells Apr 26, 2023
arpit1503khanna and others added 2 commits May 12, 2023 19:27
@arpit1503khanna @RaghavaroraSF
fix(chore): fixing sonar smells
ded82ae 
resolving sonar smells to improve quality gate

GH-111
@RaghavaroraSF
fix(chore): fix sonar code smells
c461a24 
Resolving sonar code smells to improve quality gate

GH-111
@RaghavaroraSF RaghavaroraSF force-pushed the GH-111 branch 3 times, most recently from 345a352 to 45e84c4 Compare May 12, 2023 14:22
@RaghavaroraSF
fix(chore): fix sonar code smells
9341314 
Resolving sonar smells to improve quality gate

GH-111
@sonarcloud
Copy link

sonarcloud bot commented May 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@shubhamp-sf shubhamp-sf merged commit af2ad32 into master May 16, 2023
1 check passed
@shubhamp-sf shubhamp-sf deleted the GH-111 branch May 16, 2023 16:21
@shubhamp-sf
Copy link
Contributor

🎉 This PR is included in version 6.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaghavaroraSF RaghavaroraSF RaghavaroraSF left review comments

@shubhamp-sf shubhamp-sf shubhamp-sf approved these changes

@yeshamavani yeshamavani Awaiting requested review from yeshamavani

Assignees

@RaghavaroraSF RaghavaroraSF

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix Sonar Quality Gate
4 participants
@arpit1503khanna @shubhamp-sf @yeshamavani @RaghavaroraSF