feat(provider): send notifications/messages to whatsapp or as text SMS using Twilio #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
yeshamavani
approved these changes
Feb 21, 2023
samarpan-b
approved these changes
Feb 21, 2023
|
@sadarunnisa-sf please rebase the branch |
sadarunnisa-sf
force-pushed
the
SF88-feat-twilio-dev1.0
branch
from
522baa4
to
973e7f6
Compare
yeshamavani
changed the title
|
Kudos, SonarCloud Quality Gate passed!
|
|
unable to resolve the code smell |
|
🎉 This PR is included in version 5.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
send notifications/messages to whatsapp or as text SMS using Twilio
GH-88
Description
Need to send SMS or whatsapp messages via Twilio. (https://www.twilio.com/docs/sms, https://www.twilio.com/docs/whatsapp) - Twilio is a modern communication API Used by developers for establishing communications. Twilio can be used as provider for sending SMS or Whatapp notifications
Fixes #88
This extension uses AWS SNS as SMS provider. SNS is not a good option for SMS as its delivery is unreliable. Please refer #88
Type of change
FEAT - Added Provider
How Has This Been Tested?
Unit test for twilio provider. Created twilio account and used sandbox to send SMS and whatsapp messages. Created sandbox whatsapp channel for whatsapp messages. Created messaging service SID to send SMS using twilio provider. We get "accountSid", "authToken" as from twilio for integration. Set required configurations in unit tests for the same and run test to send sms, whatsapp message and whatsapp message with media. (src/tests/unit/twilio.provider.unit.ts)
Checklist: