Skip to content
This repository has been archived by the owner on Oct 29, 2021. It is now read-only.

a Span storage specification issue #207

Closed
1046102779 opened this issue Jul 6, 2018 · 3 comments
Closed

a Span storage specification issue #207

1046102779 opened this issue Jul 6, 2018 · 3 comments

Comments

@1046102779
Copy link

1046102779 commented Jul 6, 2018

Span type include SpanID and Annotations

I think SpanID is span's own informations, and Annotations data is other infos and these may be empty

but in OpenTracing specfications, span's Operation Name belong itself。so i think Span type's definition is not friendly enough.

but in Appdash , span's OperationName is in Annotations

@keegancsmith
Copy link
Member

Note that appdash predates OpenTracing. We don't have any current plans on making major changes to the project or the wire format. I assume your issue here is minor and doesn't actually affect functionality? If not please re-open.

@1046102779
Copy link
Author

but Appdash use basictracer-go library, the basictracer follows OpenTracing specifications

@keegancsmith
Copy link
Member

OT support is an extension, not core to appdash. You can log to appdash without using OT.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants