storage/github: add commit_message_suffix as config entry #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@parkr small ask - if the new config field is empty, it should fall back to |
Adding '[ci skip]' made sense in the original implementation, when CI
was not often used to act on a status repo. In the age of GitHub
Actions, it would be helpful to be able to control whether this string
is appended.
The current implementation leaves "[ci skip]" enabled for all users,
and the user can optionally change it by adding this setting to their
storage configuration:
"commit_message_suffix": "user-defined-string"
If the user sets the suffix to a single space (" "), then it will be
disabled.
parkr
force-pushed
the
configurable-github-commit-message
branch
from
b28c931
to
798aabd
Compare
Updated. If a user wants it blank, they need to set to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding '[ci skip]' made sense in the original implementation, when CI
was not often used to act on a status repo. In the age of GitHub
Actions, it would be helpful to be able to control whether this string
is appended.
The current implementation gives the user the choice to append it by
setting the
"commit_message_suffix": "[ci skip]"field to theirconfiguration, but leaves it off by default.