New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: disable jsdoc/check-indentation
#265
Conversation
The rule doesn't work as expected and is disabled https://sourcegraph.com/search?q=context%3Aglobal+repo%3Agithub.com%2Fsourcegraph%2Fsourcegraph%24+jsdoc%2Fcheck-indentation&patternType=standard&sm=1&groupBy=repo in the main repo.
I remember @fkling bumped into it too! |
@valerybugakov Without this, do we have another rule in place that ensures we don't start arguing about tabs vs spaces? |
@vdavid I think prettier takes care of this for all JS/TS files quite well :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me the rule doesn't seem super impactful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good!
Thank you! Yes, this rule is supper annoying when you write more complex doc comments. Not quite sure what the purpose of it is anyway. |
Thanks, guys! 🎉 |
🎉 This PR is included in version 0.33.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
The rule doesn't work as expected and is disabled https://sourcegraph.com/search?q=context%3Aglobal+repo%3Agithub.com%2Fsourcegraph%2Fsourcegraph%24+jsdoc%2Fcheck-indentation&patternType=standard&sm=1&groupBy=repo in the main repo.