Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: disable jsdoc/check-indentation #265

Merged
merged 2 commits into from Dec 13, 2022

Conversation

valerybugakov
Copy link
Member

@valerybugakov valerybugakov self-assigned this Dec 13, 2022
@valerybugakov valerybugakov requested review from fkling and a team December 13, 2022 06:44
@valerybugakov
Copy link
Member Author

I remember @fkling bumped into it too!

@valerybugakov valerybugakov marked this pull request as ready for review December 13, 2022 06:45
@vdavid
Copy link

vdavid commented Dec 13, 2022

@valerybugakov Without this, do we have another rule in place that ensures we don't start arguing about tabs vs spaces?

@philipp-spiess
Copy link
Member

@valerybugakov Without this, do we have another rule in place that ensures we don't start arguing about tabs vs spaces?

@vdavid I think prettier takes care of this for all JS/TS files quite well :)

Copy link
Member

@philipp-spiess philipp-spiess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me the rule doesn't seem super impactful.

Copy link

@vdavid vdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good!

@fkling
Copy link

fkling commented Dec 13, 2022

Thank you! Yes, this rule is supper annoying when you write more complex doc comments. Not quite sure what the purpose of it is anyway.

@valerybugakov valerybugakov merged commit 6b94e39 into master Dec 13, 2022
@valerybugakov valerybugakov deleted the vb/disabled-jsdoc-indentation-rule branch December 13, 2022 12:55
@valerybugakov
Copy link
Member Author

Thanks, guys! 🎉

@sourcegraph-buildkite
Copy link
Collaborator

🎉 This PR is included in version 0.33.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants