Skip to content
This repository has been archived by the owner on Nov 6, 2018. It is now read-only.

Replace extension drop-downs with toggles #56

Merged
merged 2 commits into from
Oct 5, 2018
Merged

Conversation

chrismwendt
Copy link

  • Toggles instead of dropdowns + buttons
  • Hover on the toggle to see where the extension is enabled/disabled
  • Still asks for confirmation when enabling an extension that doesn't exist in the settings
  • Pulls in @ijsnow's new and improved toggle ✨

2018-10-04 19 21 06

ijsnow and others added 2 commits October 4, 2018 19:00
BREAKING CHANGE: ExtensionPrimaryActionButton is now called
ExtensionToggle
@codecov
Copy link

codecov bot commented Oct 5, 2018

Codecov Report

Merging #56 into master will increase coverage by 1%.
The diff coverage is 1.69%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #56   +/-   ##
=======================================
+ Coverage   15.92%   16.93%   +1%     
=======================================
  Files          36       35    -1     
  Lines        1124     1063   -61     
  Branches      287      274   -13     
=======================================
+ Hits          179      180    +1     
+ Misses        945      883   -62
Impacted Files Coverage Δ
src/extensions/manager/ExtensionCard.tsx 0% <ø> (ø) ⬆️
src/ui/generic/Toggle.tsx 0% <0%> (ø) ⬆️
src/extensions/ExtensionToggle.tsx 0% <0%> (ø)
src/settings.ts 60.6% <11.11%> (-7.82%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc258c5...66d6222. Read the comment docs.

@chrismwendt
Copy link
Author

I don't feel that the lack of client-side prediction is too janky, and I don't want to risk introducing any bugs at the moment, so I'm merging this as-is.

@chrismwendt chrismwendt merged commit 2e70392 into master Oct 5, 2018
@chrismwendt chrismwendt deleted the simplify-settings branch October 5, 2018 03:57
@sourcegraph-bot
Copy link

🎉 This PR is included in version 10.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants