This repository has been archived by the owner on Nov 6, 2018. It is now read-only.
feat: mark safe GraphQL requests #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sqs
approved these changes
Oct 17, 2018
|
Not right now. I covered all existing call sites of |
|
🎉 This PR is included in version 10.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm planning to support running extensions (e.g. Codecov) on private code even when the repository does not exist on the Sourcegraph instance. Doing so will resolve this issue: https://github.com/sourcegraph/browser-extensions/issues/234#issuecomment-430429015
The browser extension currently blocks all GraphQL requests sent from a private repository to Sourcegraph.com, but it needs to allow e-c-c to send certain GraphQL requests that fetch configuration and extension metadata (e.g. the manifest) in order to run extensions on private repositories. At the same time, it still needs to prevent GraphQL requests that might contain private information (such as repo names) up to Sourcegraph.com.
This PR marks known-safe GraphQL requests so that the browser extension can allow these requests to be sent to the Sourcegraph instance.