Skip to content
This repository has been archived by the owner on Sep 26, 2023. It is now read-only.

Investigate support for generics in Go 1.18 #240

Closed
mrnugget opened this issue Mar 23, 2022 · 2 comments
Closed

Investigate support for generics in Go 1.18 #240

mrnugget opened this issue Mar 23, 2022 · 2 comments
Assignees

Comments

@mrnugget
Copy link
Contributor

mrnugget commented Mar 23, 2022

We should check if generics cause lsif-go to crash by testing it against existing package with generics.

@Strum355
Copy link
Member

First round of investigation:

lsif-go does not panic on a codebase with generics, and the LSIF upload is succesful.
And thats mostly where the good parts end.

The hover is mostly useless, and codeintel for the type and most of the rest of the file are not precise at all
image

image

@mrnugget
Copy link
Contributor Author

Thanks! Do you plan to do another "round of investigation" in this iteration? If so, feel free to re-open, because I'm closing this now since we got what we wanted.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants