New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sourcegraph/deploy-sourcegraph#4111: "insights: Add pg_expoter for codeinsights-db" #187

Closed

sourcegraph-bot opened this issue Apr 19, 2022 · 1 comment

Assignees

Labels

approved exception/test-plan sourcegraph/deploy-sourcegraph

sourcegraph-bot commented Apr 19, 2022

sourcegraph/deploy-sourcegraph#4111 "insights: Add pg_expoter for codeinsights-db" has no test plan.

Learn more about test plans in our testing guidelines.

@caugustus-sourcegraph please comment in this issue with an explanation for this exception and close this issue.

sourcegraph-bot added exception/test-plan sourcegraph/deploy-sourcegraph labels

sourcegraph-bot assigned caugustus-sourcegraph

caugustus-sourcegraph commented Apr 19, 2022

Added test plan - just needed to test that metrics are correctly scraped by Prometheus. Confirmed!

caugustus-sourcegraph closed this as completed

jhchabran added the approved label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment