Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Skip benchmarks for dependabot #1144

Merged
merged 1 commit into from Feb 28, 2023

Conversation

shahzadlone
Copy link
Member

@shahzadlone shahzadlone commented Feb 24, 2023

Relevant issue(s)

Resolves #1143

Description

We have to replicate all github secrets for dependabot, a quick get around I want to try is to see if we can just skip the benchmark workflow for dependabot. Can turn benchmarking back on if we decide we need that once benchmarking has been fixed/improved. Other than the benchmark secrets we have a token for code cov and a ssh deploy key for defradb, both of which have been replicated in dependabot secrets.

Tasks

  • I made sure the code is well commented, particularly hard-to-understand areas.
  • I made sure the repository-held documentation is changed accordingly.
  • I made sure the pull request title adheres to the conventional commit style (the subset used in the project can be found in tools/configs/chglog/config.yml).
  • I made sure to discuss its limitations such as threats to validity, vulnerability to mistake and misuse, robustness to invalidation of assumptions, resource requirements, ...

How has this been tested?

Will need to have a dependabot PR open to test if this actually works or not.

Specify the platform(s) on which this was tested:

  • WSL - Manjaro

@shahzadlone shahzadlone added ci/build This is issue is about the build or CI system, and the administration of it. dependencies Related to dependencies labels Feb 24, 2023
@shahzadlone shahzadlone added this to the DefraDB v0.5 milestone Feb 24, 2023
@shahzadlone shahzadlone requested a review from a team February 24, 2023 05:55
@shahzadlone shahzadlone self-assigned this Feb 24, 2023
@source-devs

This comment was marked as off-topic.

@orpheuslummis
Copy link
Contributor

orpheuslummis commented Feb 24, 2023

We prefer to run benchmarks.
Benchmarks are currently high variance making them not useful as a point estimate. That's a problem we will fix. Once that is fixed, hopefully in a matter of weeks, we will activate benchmarks on dependabot. To me it seems simpler to just activate them now via secrets instead of disabling them now and activating them later.

@shahzadlone
Copy link
Member Author

We prefer to run benchmarks. Benchmarks are currently high variance making them not useful as a point estimate. That's a problem we will fix. Once that is fixed, hopefully in a matter of weeks, we will activate benchmarks on dependabot. To me it seems simpler to just activate them now via secrets instead of disabling them now and activating them later.

There are two problems with benchmarks right now:

  1. the broken ci - due to benchstat update.
  2. the variance issue.

By default the way dependabot is setup it will trigger the SHORT benchmark flow. So even if we do want to turn benchmarking on we can change that to FULL later.

Up till now I haven't seen us bump dependencies only after benchmarking, it seems like a "nice thing to have", but not something worth blocking dependabot usability.

Copy link
Contributor

@orpheuslummis orpheuslummis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but IMO I wish to re-enable it soon

@orpheuslummis
Copy link
Contributor

One thing that we should consider disabling is codecov for dependabot

@shahzadlone shahzadlone force-pushed the lone/ci/ignore-benchmarks-for-dependabot branch from 173a378 to 6a6fd03 Compare February 28, 2023 03:59
@sourcenetwork sourcenetwork deleted a comment from source-devs Feb 28, 2023
@shahzadlone shahzadlone merged commit 92a7f89 into develop Feb 28, 2023
@shahzadlone shahzadlone deleted the lone/ci/ignore-benchmarks-for-dependabot branch February 28, 2023 04:16
shahzadlone added a commit that referenced this pull request Apr 13, 2023
PR: Skip benchmarks if pull_request is triggered by dependabot.
shahzadlone added a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
PR: Skip benchmarks if pull_request is triggered by dependabot.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/build This is issue is about the build or CI system, and the administration of it. dependencies Related to dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skip benchmark if ci triggered by dependabot
3 participants