New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Skip benchmarks for dependabot #1144
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
We prefer to run benchmarks. |
There are two problems with benchmarks right now:
By default the way dependabot is setup it will trigger the Up till now I haven't seen us bump dependencies only after benchmarking, it seems like a "nice thing to have", but not something worth blocking dependabot usability. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but IMO I wish to re-enable it soon
One thing that we should consider disabling is codecov for dependabot |
173a378
to
6a6fd03
Compare
PR: Skip benchmarks if pull_request is triggered by dependabot.
PR: Skip benchmarks if pull_request is triggered by dependabot.
Relevant issue(s)
Resolves #1143
Description
We have to replicate all github secrets for dependabot, a quick get around I want to try is to see if we can just skip the benchmark workflow for dependabot. Can turn benchmarking back on if we decide we need that once benchmarking has been fixed/improved. Other than the benchmark secrets we have a token for code cov and a ssh deploy key for defradb, both of which have been replicated in dependabot secrets.
Tasks
How has this been tested?
Will need to have a dependabot PR open to test if this actually works or not.
Specify the platform(s) on which this was tested: