test: Explicitly state change detector split for test #1228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test caused the change detector to auto-split between setup and run incorrectly causing a test failure. Here we explicitly tell it to split between the two schema changes.
AndrewSisley
added
bug
Codecov Report
@@ Coverage Diff @@
## develop #1228 +/- ##
===========================================
- Coverage 68.61% 68.58% -0.04%
===========================================
Files 181 181
Lines 17144 17144
===========================================
- Hits 11764 11758 -6
- Misses 4422 4426 +4
- Partials 958 960 +2 |
Benchmark ResultsSummary
✅ See Better Results...
❌ See Worse Results...
✨ See Unchanged Results...
🐋 See Full Results... |
|||||||||||||||
AndrewSisley
added
the
action/no-benchmark
shahzadlone
pushed a commit
that referenced
this pull request
Apr 13, 2023
This test caused the change detector to auto-split between setup and run incorrectly causing a test failure. Here we explicitly tell it to split between the two schema changes.
shahzadlone
pushed a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
…1228) This test caused the change detector to auto-split between setup and run incorrectly causing a test failure. Here we explicitly tell it to split between the two schema changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #1227
Description
Explicitly states the change detector split for
TestSchemaSimpleErrorsGivenDuplicateSchema. This test caused the change detector to auto-split between setup and run incorrectly causing a test failure. Here we explicitly tell it to split between the two schema changes.