fix: Explain of _group with dockeys filter to be []string #1348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahzadlone
added
bug
shahzadlone
changed the title
shahzadlone
changed the title
Codecov Report
@@ Coverage Diff @@
## develop #1348 +/- ##
========================================
Coverage 70.67% 70.67%
========================================
Files 184 184
Lines 17820 17819 -1
========================================
Hits 12594 12594
Misses 4273 4273
+ Partials 953 952 -1
|
| if c.DocKeys.HasValue() { | ||
| childExplainGraph["docKeys"] = c.DocKeys.Value | ||
| childExplainGraph["docKeys"] = c.DocKeys.Value() |
There was a problem hiding this comment.
lol - is one to to keep an eye out for in the future, good spot 😆
There was a problem hiding this comment.
if only we had a anyButNotAFunc instead of any haha.
shahzadlone
added a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
…ork#1348) Fixes the bug in simple explain attribute of group node that was causing `"docKeys":(func() []string)0x132ea40`. But we expected it to be `"docKeys": []string{"bae-6a4c5bc5-b044-5a03-a868-8260af6f2254"}`. Also add a test for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
[]string#1347Description
Fixes the bug in simple explain attribute of group node that was causing
"docKeys":(func() []string)0x132ea40.But we expected it to be
"docKeys": []string{"bae-6a4c5bc5-b044-5a03-a868-8260af6f2254"}.Also add a test for it.
How has this been tested?
Integration test + CI
Specify the platform(s) on which this was tested: