fix: Unlock replicator lock before returning error #1369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewSisley
added
bug
AndrewSisley
force-pushed
the
sisley/fix/I1367-unlock-lock
branch
from
88613bc
to
c5d355f
Compare
Codecov Report
@@ Coverage Diff @@
## develop #1369 +/- ##
===========================================
- Coverage 70.65% 70.55% -0.10%
===========================================
Files 184 184
Lines 17835 17836 +1
===========================================
- Hits 12601 12585 -16
- Misses 4282 4294 +12
- Partials 952 957 +5
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #1367
Description
Unlocks a lock that is held before returning an error.
Unlikely to be tripping up any of our tests, but is undesirable and should be fixed.