test: Convert filter explain tests to new explain setup #1380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahzadlone
added
the
action/no-benchmark
| (explainTest.ExpectedFullGraph != nil || | ||
| explainTest.ExpectedPatterns != nil || | ||
| explainTest.ExpectedTargets != nil) { | ||
| require.Fail(t, "Expected error should not have other expected results with it.", explainTest.Description) |
AndrewSisley
approved these changes
Apr 20, 2023
|
For some odd reason I don't know why CodeCov report isn't showing. I really want to ensure code coverage doesn't change. |
shahzadlone
deleted the
lone/refactor/convert-basic-default-explain-tests-to-new-setup
branch
shahzadlone
added a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
…k#1380) - Part of sourcenetwork#953 - Resolves sourcenetwork#1379 - Continue converting explain tests to the new explain setup before we can integrate the entire setup to the new action based setup. sourcenetwork#953 Has a lot more detail on the entire plan. - Removes example tests that we don't need any more, if there is anything in them documentation wise that a reviewer wants found helpful I can introduce a README.md upon request. - Removes some tests that provide no value wrt to non-execution explain tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Description
Continue converting explain tests to the new explain setup before we can integrate the entire setup to the new action based setup. #953 Has a lot more detail on the entire plan.