fix: Do not commit if errors have been returned #1390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewSisley
added
bug
AndrewSisley
force-pushed
the
1382-lost-err-2
branch
from
843648e
to
002bbf1
Compare
AndrewSisley
force-pushed
the
1382-lost-err-2
branch
from
22de548
to
3118d36
Compare
Codecov Report
@@ Coverage Diff @@
## develop #1390 +/- ##
===========================================
+ Coverage 70.56% 70.66% +0.09%
===========================================
Files 184 184
Lines 17836 17838 +2
===========================================
+ Hits 12586 12605 +19
+ Misses 4293 4281 -12
+ Partials 957 952 -5
|
shahzadlone
pushed a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
* Add test for create with non-existant field * Do not commit if errors have been returned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #1382
Description
Does not commit if errors have been returned. This allowed changes to be persisted on error.
Note: First commit documents the error, second commit fixes it.