fix: Serialize DB errors to json in http package #1401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewSisley
added
bug
AndrewSisley
force-pushed
the
1383-err-json
branch
from
137913a
to
b74662a
Compare
AndrewSisley
changed the title
AndrewSisley
force-pushed
the
1383-err-json
branch
from
b74662a
to
8a62721
Compare
Codecov Report
@@ Coverage Diff @@
## develop #1401 +/- ##
===========================================
+ Coverage 70.71% 70.76% +0.04%
===========================================
Files 184 185 +1
Lines 17875 17884 +9
===========================================
+ Hits 12641 12655 +14
+ Misses 4282 4279 -3
+ Partials 952 950 -2
|
shahzadlone
reviewed
Apr 24, 2023
Comment on lines
+23
to
+25
| for i := range r.Errors { | ||
| errors[i] = r.Errors[i].Error() | ||
| } |
There was a problem hiding this comment.
nitpick:
Suggested change
| for i := range r.Errors { | |
| errors[i] = r.Errors[i].Error() | |
| } | |
| for i, e := range r.Errors { | |
| errors[i] = e.Error() | |
| } |
There was a problem hiding this comment.
Ah, I'm happy with either. Leaving as is
api/http/handlerfuncs_test.go
Outdated
| ) {_key} | ||
| }" | ||
| }` | ||
| // remote line returns and tabulation from formatted statement |
There was a problem hiding this comment.
typo: Do you mean replace instead of remote?
There was a problem hiding this comment.
My bad, this comment is here to indicate that the PR author's brain auto-filtered out the comments and failed to remove it having copy-pasted from the test above.
- remove?
Test is quite lazy/bad as it doesnt really show that the returned error is just an empty object, but it is very temporary
AndrewSisley
force-pushed
the
1383-err-json
branch
from
8a62721
to
5f424ae
Compare
shahzadlone
pushed a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
* Add test for http errors Test is quite lazy/bad as it doesnt really show that the returned error is just an empty object, but it is very temporary * Serialize db errors to json correctly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #1383
Description
Serializes DB errors to json in http package. They were previously resolving to
"{}".