Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update graphql-go #1422

Conversation

fredcarle
Copy link
Collaborator

@fredcarle fredcarle commented Apr 28, 2023

Relevant issue(s)

Resolves #1400

Description

This PR updates to the latest version of graphql-go. The update changed the formatting of object.Name() which caused issued with our gql parsing and filtering.

Thanks to @AndrewSisley for sorting our the gql issues.

Tasks

  • I made sure the code is well commented, particularly hard-to-understand areas.
  • I made sure the repository-held documentation is changed accordingly.
  • I made sure the pull request title adheres to the conventional commit style (the subset used in the project can be found in tools/configs/chglog/config.yml).
  • I made sure to discuss its limitations such as threats to validity, vulnerability to mistake and misuse, robustness to invalidation of assumptions, resource requirements, ...

make test

(replace) Describe the tests performed to verify the changes. Provide instructions to reproduce them.

Specify the platform(s) on which this was tested:

  • MacOS

@fredcarle fredcarle added action/no-benchmark Skips the action that runs the benchmark. dependencies Related to dependencies labels Apr 28, 2023
@fredcarle fredcarle added this to the DefraDB v0.5.1 milestone Apr 28, 2023
@fredcarle fredcarle requested a review from a team April 28, 2023 17:41
@fredcarle fredcarle self-assigned this Apr 28, 2023
@codecov
Copy link

codecov bot commented Apr 28, 2023

Codecov Report

Merging #1422 (c2afdcc) into develop (574a247) will increase coverage by 0.15%.
The diff coverage is 100.00%.

❗ Current head c2afdcc differs from pull request most recent head 98af346. Consider uploading reports for the commit 98af346 to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1422      +/-   ##
===========================================
+ Coverage    72.09%   72.25%   +0.15%     
===========================================
  Files          185      185              
  Lines        18160    18166       +6     
===========================================
+ Hits         13093    13126      +33     
+ Misses        4028     4009      -19     
+ Partials      1039     1031       -8     
Impacted Files Coverage Δ
request/graphql/schema/generate.go 85.53% <100.00%> (+0.66%) ⬆️

... and 5 files with indirect coverage changes

Copy link
Contributor

@AndrewSisley AndrewSisley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I was involved in the development of it, suggest waiting a bit to see if anyone else reviews it before merge.

One minor code change requested, and one other todo that may or may not result in a code change here.

request/graphql/schema/generate.go Outdated Show resolved Hide resolved
request/graphql/schema/generate.go Show resolved Hide resolved
@fredcarle fredcarle force-pushed the fredcarle/chore/I1400-update-graphql branch from 0d5150a to c2afdcc Compare May 3, 2023 23:30
@fredcarle fredcarle force-pushed the fredcarle/chore/I1400-update-graphql branch from c2afdcc to 98af346 Compare May 4, 2023 19:00
@fredcarle fredcarle merged commit 18221b9 into sourcenetwork:develop May 4, 2023
9 checks passed
shahzadlone pushed a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
## Relevant issue(s)

Resolves #

## Description

This PR updates to the latest version of graphql-go. The update changed
the formatting of `object.Name()` which caused issued with our gql
parsing and filtering.

Thanks to @AndrewSisley for sorting our the gql issues.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action/no-benchmark Skips the action that runs the benchmark. dependencies Related to dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Security issue affecting graphql-go <= 0.8.0
2 participants