-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update graphql-go #1422
chore: Update graphql-go #1422
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1422 +/- ##
===========================================
+ Coverage 72.09% 72.25% +0.15%
===========================================
Files 185 185
Lines 18160 18166 +6
===========================================
+ Hits 13093 13126 +33
+ Misses 4028 4009 -19
+ Partials 1039 1031 -8
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I was involved in the development of it, suggest waiting a bit to see if anyone else reviews it before merge.
One minor code change requested, and one other todo that may or may not result in a code change here.
0d5150a
to
c2afdcc
Compare
c2afdcc
to
98af346
Compare
## Relevant issue(s) Resolves # ## Description This PR updates to the latest version of graphql-go. The update changed the formatting of `object.Name()` which caused issued with our gql parsing and filtering. Thanks to @AndrewSisley for sorting our the gql issues.
Relevant issue(s)
Resolves #1400
Description
This PR updates to the latest version of graphql-go. The update changed the formatting of
object.Name()
which caused issued with our gql parsing and filtering.Thanks to @AndrewSisley for sorting our the gql issues.
Tasks
make test
(replace) Describe the tests performed to verify the changes. Provide instructions to reproduce them.
Specify the platform(s) on which this was tested: