chore: Improve logging consistency #1424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orpheuslummis
added
the
action/no-benchmark
Codecov Report
@@ Coverage Diff @@
## develop #1424 +/- ##
===========================================
+ Coverage 72.03% 72.23% +0.19%
===========================================
Files 185 185
Lines 18185 18160 -25
===========================================
+ Hits 13100 13118 +18
+ Misses 4048 4010 -38
+ Partials 1037 1032 -5
|
AndrewSisley
approved these changes
May 1, 2023
orpheuslummis
force-pushed
the
orpheus/chore/logging-consistency
branch
from
1d7e74d
to
81fc86c
Compare
shahzadlone
pushed a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
## Relevant issue(s) Improves on sourcenetwork#1430 (but doesn't resolve it) ## Description - fix one SchemaID value logging the function instead of the resulting of calling the function - more consistency. prefer PeerID over PID ## Tasks - [x] I made sure the code is well commented, particularly hard-to-understand areas. - [x] I made sure the repository-held documentation is changed accordingly. - [x] I made sure the pull request title adheres to the conventional commit style (the subset used in the project can be found in [tools/configs/chglog/config.yml](tools/configs/chglog/config.yml)). - [x] I made sure to discuss its limitations such as threats to validity, vulnerability to mistake and misuse, robustness to invalidation of assumptions, resource requirements, ... ## How has this been tested? CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Tackles #1430 (but doesn't fully resolve it)
Description
Tasks
How has this been tested?
CI