Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add a separate workflow to run the linter #1434

Merged

Conversation

shahzadlone
Copy link
Member

@shahzadlone shahzadlone commented May 1, 2023

Relevant issue(s)

Resolves #1435

Description

Add a Lint only workflow.

How has this been tested?

CI on branch of a fork and this PR

@shahzadlone shahzadlone added action/no-benchmark Skips the action that runs the benchmark. ci/build This is issue is about the build or CI system, and the administration of it. labels May 1, 2023
@shahzadlone shahzadlone self-assigned this May 1, 2023
@shahzadlone shahzadlone added this to the DefraDB v0.5.1 milestone May 1, 2023
@shahzadlone shahzadlone marked this pull request as ready for review May 1, 2023 18:02
@codecov
Copy link

codecov bot commented May 1, 2023

Codecov Report

Merging #1434 (9cf98b0) into develop (0e3801e) will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1434      +/-   ##
===========================================
- Coverage    72.21%   72.17%   -0.05%     
===========================================
  Files          185      185              
  Lines        18160    18160              
===========================================
- Hits         13115    13107       -8     
- Misses        4012     4018       +6     
- Partials      1033     1035       +2     

see 4 files with indirect coverage changes

@shahzadlone shahzadlone changed the title ci: Add a separated lint workflow ci: Add a separated workflow to run the linter May 1, 2023
@shahzadlone shahzadlone changed the title ci: Add a separated workflow to run the linter ci: Add a separate workflow to run the linter May 1, 2023
@shahzadlone shahzadlone requested a review from a team May 1, 2023 18:15
@AndrewSisley
Copy link
Contributor

question: Why does this not remove the lint stuff from the lint-then-benchmark workflow?

@shahzadlone
Copy link
Member Author

shahzadlone commented May 1, 2023

question: Why does this not remove the lint stuff from the lint-then-benchmark workflow?

That entire workflow file will be disabled after this is merged. I don't want to make changes to that workflow as it will be dead until we fix it (would rather preserve it in the state it used to work rather than in a changed further broken state).

@AndrewSisley
Copy link
Contributor

question: Why does this not remove the lint stuff from the lint-then-benchmark workflow?

That entire workflow file will be disabled after this is merged. I don't want to make changes to that workflow as it will be dead until we fix it (would rather preserve it in the state it used to work rather than in a changed further broken state).

Those are good reasons, cheers for the explanation :)

Copy link
Contributor

@AndrewSisley AndrewSisley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@shahzadlone shahzadlone merged commit 483a23a into sourcenetwork:develop May 1, 2023
13 checks passed
@shahzadlone shahzadlone deleted the lone/ci/separate-lint-rule branch May 1, 2023 18:46
shahzadlone added a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
## Relevant issue(s)
Resolves sourcenetwork#1435

## Description
Add a Lint only workflow.

## How has this been tested?
CI on branch of a fork and this PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action/no-benchmark Skips the action that runs the benchmark. ci/build This is issue is about the build or CI system, and the administration of it.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Separate linter so we can disable benchmark flow until it's fixed
2 participants