Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update QL documentation link and replicator command #1440

Merged
merged 1 commit into from
May 1, 2023
Merged

fix: Update QL documentation link and replicator command #1440

merged 1 commit into from
May 1, 2023

Conversation

fredcarle
Copy link
Collaborator

Relevant issue(s)

Resolves #1439

Description

This PR fixes the link to the query language documentation in the Readme file as well as removing an inaccurate CLI command for setting a replicator.

Tasks

  • I made sure the code is well commented, particularly hard-to-understand areas.
  • I made sure the repository-held documentation is changed accordingly.
  • I made sure the pull request title adheres to the conventional commit style (the subset used in the project can be found in tools/configs/chglog/config.yml).
  • I made sure to discuss its limitations such as threats to validity, vulnerability to mistake and misuse, robustness to invalidation of assumptions, resource requirements, ...

How has this been tested?

N/A

@fredcarle fredcarle added the documentation Improvements or additions to documentation label May 1, 2023
@fredcarle fredcarle added this to the DefraDB v0.5.1 milestone May 1, 2023
@fredcarle fredcarle requested a review from a team May 1, 2023 21:46
@fredcarle fredcarle self-assigned this May 1, 2023
orpheuslummis
orpheuslummis approved these changes May 1, 2023
View reviewed changes
Copy link
Contributor

@orpheuslummis orpheuslummis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shahzadlone
shahzadlone approved these changes May 1, 2023
View reviewed changes
Copy link
Member

@shahzadlone shahzadlone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fredcarle fredcarle merged commit a6bed22 into sourcenetwork:develop May 1, 2023
8 checks passed
@fredcarle fredcarle deleted the fredcarle/fix/I1439-readme branch May 1, 2023 21:55
shahzadlone pushed a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
@fredcarle
fix: Update QL documentation link and replicator command (sourcenetwo…
e6d5c16 
…rk#1440)

## Relevant issue(s)

Resolves sourcenetwork#1439

## Description

This PR fixes the link to the query language documentation in the Readme
file as well as removing an inaccurate CLI command for setting a
replicator.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orpheuslummis orpheuslummis orpheuslummis approved these changes

@shahzadlone shahzadlone shahzadlone approved these changes

Assignees

@fredcarle fredcarle

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
DefraDB v0.5.1
Development

Successfully merging this pull request may close these issues.

Readme has some errors
3 participants
@fredcarle @orpheuslummis @shahzadlone