Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Convert explain limit tests to new explain setup #1446

Conversation

shahzadlone
Copy link
Member

Relevant issue(s)

Description

Continue converting explain tests to the new explain setup before we can integrate the entire setup to the new action based setup. #953 Has a lot more detail on the entire plan.

This PR converts all the default limit explain tests to the new explain setup.

Splits limit tests into multiple files.

@shahzadlone shahzadlone added area/testing Related to any test or testing suite code quality Related to improving code quality labels May 3, 2023
@shahzadlone shahzadlone added this to the DefraDB v0.5.1 milestone May 3, 2023
@shahzadlone shahzadlone requested a review from a team May 3, 2023 08:48
@shahzadlone shahzadlone self-assigned this May 3, 2023
@shahzadlone shahzadlone force-pushed the tests/convert-limit-default-explain-tests branch from 6a6675f to a0976df Compare May 3, 2023 08:56
@shahzadlone shahzadlone changed the title test: Convert default explain limit tests to new explain setup test: Convert explain limit tests to new explain setup May 3, 2023
@codecov
Copy link

codecov bot commented May 3, 2023

Codecov Report

Merging #1446 (6a6675f) into develop (a6bed22) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 6a6675f differs from pull request most recent head a0976df. Consider uploading reports for the commit a0976df to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1446      +/-   ##
===========================================
+ Coverage    72.20%   72.21%   +0.01%     
===========================================
  Files          185      185              
  Lines        18160    18160              
===========================================
+ Hits         13113    13115       +2     
+ Misses        4014     4012       -2     
  Partials      1033     1033              

see 1 file with indirect coverage changes

Copy link
Contributor

@AndrewSisley AndrewSisley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@shahzadlone shahzadlone merged commit 1f1d5ce into sourcenetwork:develop May 3, 2023
10 of 11 checks passed
@shahzadlone shahzadlone deleted the tests/convert-limit-default-explain-tests branch May 3, 2023 21:01
shahzadlone added a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
…#1446)

## Relevant issue(s)
- Part of sourcenetwork#953
- Resolves sourcenetwork#1429

## Description
Continue converting explain tests to the new explain setup before we can
integrate the entire setup to the new action based setup. sourcenetwork#953 Has a lot
more detail on the entire plan.

This PR converts all the default limit explain tests to the new explain
setup.

Splits limit tests into multiple files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing Related to any test or testing suite code quality Related to improving code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert default limit explain tests
2 participants