fix: Handling SIGTERM in CLI start command
#1459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orpheuslummis
changed the title
start to handle SIGTERM signalstart command
Confirmed, it kills the test. |
AndrewSisley
approved these changes
May 5, 2023
|
proof of manual test :P
|
Codecov Report
@@ Coverage Diff @@
## develop #1459 +/- ##
===========================================
+ Coverage 72.08% 72.22% +0.13%
===========================================
Files 185 185
Lines 18224 18224
===========================================
+ Hits 13137 13162 +25
+ Misses 4044 4026 -18
+ Partials 1043 1036 -7
|
shahzadlone
pushed a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
## Relevant issue(s) Resolves sourcenetwork#1458 ## Description Simply adds SIGTERM to the list of handled signals. We can send send a signal, `syscall.Kill(syscall.Getpid(), syscall.SIGINT)` within an integration test but it will end the test process which also is running the other tests. It might require an 'external' integration test suite in which we can run the command and then send the signal to the process. ## Tasks - [x] I made sure the code is well commented, particularly hard-to-understand areas. - [x] I made sure the repository-held documentation is changed accordingly. - [x] I made sure the pull request title adheres to the conventional commit style (the subset used in the project can be found in [tools/configs/chglog/config.yml](tools/configs/chglog/config.yml)). - [x] I made sure to discuss its limitations such as threats to validity, vulnerability to mistake and misuse, robustness to invalidation of assumptions, resource requirements, ... ## How has this been tested? Manually
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #1458
Description
Simply adds SIGTERM to the list of handled signals.
I'm unsure how to test this. We can send send a signal,
syscall.Kill(syscall.Getpid(), syscall.SIGINT)within an integration test but I'm worried it will end the test process which also is running the other tests.It might require an 'external' integration test suite in which we can run the command and then send the signal to the process.
Tasks
How has this been tested?
Manually