-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Improve rollback on peer P2P collection error #1461
refactor: Improve rollback on peer P2P collection error #1461
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1461 +/- ##
===========================================
+ Coverage 72.03% 72.25% +0.22%
===========================================
Files 185 185
Lines 18224 18226 +2
===========================================
+ Hits 13127 13169 +42
+ Misses 4052 4021 -31
+ Partials 1045 1036 -9
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks better - cheer Fred, I think there are still a couple of holes here, but they are harder to plug and can perhaps be done later :)
19e840b
to
ca18f6e
Compare
ca18f6e
to
4ae9d3e
Compare
…k#1461) ## Relevant issue(s) Resolves sourcenetwork#1389 ## Description This PR improves the rollback of P2P collection manipulation errors. It ensures that a rollback is applied if the transaction commit fails.
Relevant issue(s)
Resolves #1389
Description
This PR improves the rollback of P2P collection manipulation errors. It ensures that a rollback is applied if the transaction commit fails.
Tasks
How has this been tested?
Unit test coming with
net
package code coverage improvements.